Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple productions expect the same token, the returned error does not say which production failed. Prefix errors created by Participle with that production's name (
Date: unexpected token ...) and preserve the name when backtracking selects a cached error. Custom errors keep their existing behavior; anonymous productions and plain trailing-input errors remain unnamed.Closes #419.
Tests cover shared terminators, cached/tied errors, root productions, custom errors, and concurrent parsing. With Go 1.26.3, root/example tests and root race tests pass. Local golangci-lint 2.13.1 passes; the repository-pinned 2.12.2 was not run.
On amd64,
UnexpectedTokenErrorgrows by 16 bytes. Go 1.26.3 benchmarks show unchanged EBNF B/op and allocs/op; Issue143 uses 1,280 more B/op (2.07%) with unchanged allocs/op. Timing samples are inconclusive.